Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWX-32901: Update aws-iam-authenticator in Stork container #1472

Merged
merged 2 commits into from
Aug 16, 2023
Merged

PWX-32901: Update aws-iam-authenticator in Stork container #1472

merged 2 commits into from
Aug 16, 2023

Conversation

pp511
Copy link
Contributor

@pp511 pp511 commented Aug 11, 2023 •
edited
Loading

What type of PR is this?

bug

What this PR does / why we need it:
Update aws-iam-authenticator binary to the latest version and use -Lo option.

Is a release note needed?:

Issue: aws-iam-authenticator binary size was 0 in the Stork container.
User Impact: Users using Kubeconfig with aws-iam-authenticator will fail to create cluster pair on EKS
Resolution: Updated the aws-iam-authenticator and updating the curl options to make sure binary gets downloaded

Does this change need to be cherry-picked to a release branch?:
yes, 23.7.1

@pp511
PWX-32901: Update aws-iam-authenticator in Stork container
56c8fe8 
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
@pp511 pp511 requested a review from adityadani August 11, 2023 20:04
@cnbu-jenkins
Copy link
Collaborator

Can one of the admins verify this patch?

@pp511 pp511 merged commit d0ab625 into master Aug 16, 2023
2 checks passed
pp511 added a commit that referenced this pull request Aug 16, 2023
@pp511
PWX-32901: Update aws-iam-authenticator in Stork container (#1472)
15ff6a7 
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
pp511 added a commit that referenced this pull request Aug 16, 2023
@pp511
PWX-32901: Update aws-iam-authenticator in Stork container (#1472)
af6123d 
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
@pp511 pp511 deleted the PWX-32901-aws-iam-aut branch August 16, 2023 16:33
pp511 added a commit that referenced this pull request Aug 17, 2023
@pp511
PWX-32901: Update aws-iam-authenticator in Stork container (#1472) (#…
d4e62cd 
…1476)

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
pp511 added a commit that referenced this pull request Aug 17, 2023
@pp511
PWX-32901: Update aws-iam-authenticator in Stork container (#1472) (#…
562d29e 
…1475)

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityadani adityadani adityadani approved these changes

@diptiranjanpx diptiranjanpx diptiranjanpx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pp511 @cnbu-jenkins @adityadani @diptiranjanpx